Update _edge_node.py, add device id to update topic #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @b-keesing ! |
kithix
reviewed
Mar 19, 2024
|
I ran into the same issue as well. The proposed fix worked on my end. Looking forward to the merge and updated package. |
Co-authored-by: E T <2345226+kithix@users.noreply.github.com>
|
Hello! I ran into the same issue and this fixed it. Any chance we can merge this? @matteosox |
matteosox
approved these changes
May 6, 2024
matteosox
merged commit 3334d8c
into
matteosox:matt/prep-0.3.2-release
16 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding device id to d_data_topic in method EdgeNode.update_device.
Why?
Method doesn't currently update the device metrics when called.